Re: [Xen-devel] [PATCH v9 08/13] Add IOREQ_TYPE_VMWARE_PORT

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-02-16 at 18:05 -0500, Don Slutz wrote:

>  tools/libxc/xc_hvm_build_x86.c         |   5 +-
>  tools/libxl/libxl_dm.c                 |   4 +

I've only looked at these bits.

> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index c27f9a4..620013c 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -765,6 +765,10 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>                                              machinearg, max_ram_below_4g);
>              }
>          }
> +        if (libxl_defbool_val(c_info->vmware_port)) {
> +            machinearg = libxl__sprintf(gc, "%s,vmport=on",
> +                                        machinearg);

Please use GCSPRINTF, then I think this will fit on one line.

I think you also also don't need the {}'s for a single line if.

With those fixed the tools/* bits are:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel