Re: [Xen-devel] [PATCH v2 5/5] libxc: rumpxen: provide xc_osdep_info

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Wei Liu, le Tue 03 Mar 2015 16:41:23 +0000, a écrit :
> On Tue, Mar 03, 2015 at 05:05:29PM +0100, Samuel Thibault wrote:
> > Wei Liu, le Tue 03 Mar 2015 15:57:21 +0000, a écrit :
> > > This allows programs which use the bulk of libxc to link.  We use
> > > /dev/xenevt for event channels, the raw minios functions for privcmd
> > > and gnttab, and the netbsd versions of discard_file_cache and
> > > xc_memalign.
> > > 
> > > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> > 
> > > +static xc_osdep_handle minios_privcmd_open(xc_interface *xch)
> > > +{
> > > +    return 1;
> > > +}
> > > +static xc_osdep_handle minios_gnttab_open(xc_gnttab *xcg)
> > > +{
> > > +    return 1;
> > > +}
> > 
> > Perhaps return a different fd number?
> > 
> 
> After thinking a bit more I think we should use alloc_fd(FTYPE_*) for
> all file descriptor allocation.

That would make sense, yes.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel