Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number 
when parsing values"):
> Ack. This is how it looks like now. The changes are
> 
> 1. Use YYLTYPE instead of line and column.

This is better but why not have YYLTYPE inside XLU_ConfigValue ?

> 2. Handle empty rule inside list_mk and string_mk (that is when YYLTYPE
>    points to NULL)

I hadn't spotted this in the previous patch.  Why not use `yyloc', the
location of the lookahead token ?

> +    if (loc) {
> +        value->line = loc->first_line;
> +        value->column = loc->first_column;
> +    } else
> +        value->line = value->column = 0;

This code appears twice.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel