Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add Cadence UART driver

["Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>]

On Mon, Mar 09, 2015 at 12:47:51PM +0200, Julien Grall wrote:
> Hi Edgar,

Hi Julien,

> 
> On 06/03/2015 03:08, Edgar E. Iglesias wrote:
> >+#define cuart_read(uart, off)           readl((uart)->regs + (off))
> >+#define cuart_write(uart, off,val)      writel((val), (uart)->regs + (off))
> >+
> >+static void cuart_interrupt(int irq, void *data, struct cpu_user_regs *regs)
> >+{
> >+    struct serial_port *port = data;
> >+    struct cuart *uart = port->uart;
> >+    unsigned int status;
> >+
> >+    do {
> >+        status = cuart_read(uart, R_UART_SR);
> >+        /* ACK.  */
> >+        if (status & UART_SR_INTR_RTRIG) {
> 
> 
> [..]
> 
> >+static void __init cuart_init_postirq(struct serial_port *port)
> >+{
> >+    struct cuart *uart = port->uart;
> >+    int rc;
> >+
> >+    if ( uart->irq > 0 ) {
> 
> Can you be consistent with the coding style? Either use Linux or Xen
> one but not a mix of them.

Yes, I'll fix it up and send a v3.

Thanks,
Edgar

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel