Re: [Xen-devel] [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-09 at 14:00 +0200, Julien Grall wrote:
> Hi Ian,
> 
> On 05/03/2015 19:00, Ian Campbell wrote:
> > On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote:
> >> +    gicv3_info.nr_lines = min((unsigned)1020, nr_lines);
> >
> > "1020U" is the correct way to write (unsigned)1020 I think (in both
> > places).
> 
> I gave a look on several usage of min in arch/arm and (unsigned) was used.

I don't see any with a literal number, which is the main point.
(unsigned)PAGE_SIZE is fine, because you can't write PAGE_SIZEU very
easily. (Leaving aside whether PAGE_SIZE should be unsigned in its
definition.
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel