[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv6 1/3] arm: make __get_user() work for 8 byte values



On Fri, Mar 06, 2015 at 12:58:33PM +0000, David Vrabel wrote:
> diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
> index ce0786e..d8f535b 100644
> --- a/arch/arm/include/asm/uaccess.h
> +++ b/arch/arm/include/asm/uaccess.h
> @@ -306,6 +306,7 @@ do {                                                      
>                 \
>       case 1: __get_user_asm_byte(__gu_val, __gu_addr, err);  break;  \
>       case 2: __get_user_asm_half(__gu_val, __gu_addr, err);  break;  \
>       case 4: __get_user_asm_word(__gu_val, __gu_addr, err);  break;  \
> +     case 8: __get_user_asm_dword(__gu_val, __gu_addr, err); break;  \

Obviously not tested.  __gu_val is an unsigned long - it's 32-bit.  This
will truncate the 64-bit read into 32-bits.

It's going to take some work to sort out something that works, and
right now I don't have time for that (catching up post-op, sorry).

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.