Re: [Xen-devel] [PATCH] xen/passthrough: share_p2m: fix build failure on ARM

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-03-11 at 11:23 +0000, Julien Grall wrote:
> The commit 7978429 "iommu: fix usage of shared EPT/IOMMU page tables on
> PVH guests" breaks the hypervisor compilation on ARM.
> 
> This is because the macro hap_enabled is not defined on ARM.
> 
> On x86, the P2M can only be shared when hap is enabled and the user
> didn't deny it (via the command line). Those checks are done by
> iommu_use_hap_pt().
> 
> On ARM, the macro iommu_use_hap_pt() is also defined. So move the
> if ( iommu_use_hap_pt(d) ) from the IOMMU drivers up to
> iommu_share_p2m_table.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> Cc: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

Reviewed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Since this is breaking the arm build (as I suppose osstest will tell us
shortly) it would be good to get this into the tree ASAP.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel