Re: [Xen-devel] [PATCH v2 3/6] tools/libxl: Avoid overrunning static buffer with prefixdata

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-06 at 19:05 +0000, Andrew Cooper wrote:
> From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> 
> An individual datacopier_buf contains a static buffer of 1000 bytes.
> Attempting to add prefixdata of more than 1000 bytes would overrun the buffer
> and cause heap corruption.
> 
> Instead, split the prefixdata and chain together multiple datacopier buffers.
> This allows for an arbitrary quantity of prefixdata to be added to a
> datacopier.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel