Re: [Xen-devel] [PATCH] libxc: use xc_dom_panic when decompressor is not supported

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-06 at 12:43 +0000, Andrew Cooper wrote:
> On 06/03/2015 11:33, Wei Liu wrote:
> > State explicitly that specific decompressor is not supported by libxc.
> > Without this change, libxc error message only says the provided kernel
> > is invalid, which is misleading.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: svenvan.van@xxxxxxxxx
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked + applied.

> I did the triage of this issue when reported on #xen.  `xl -vvv
> create...` does eventually reveal the issue, where `xl create` gives an
> incorrect error message.
> 
> (although s/__FUNCTION__/__func__/ to be more C99 if you have cause to
> resubmit)

FWIW this whole file uses __FUNCTION__, probably would be better to do
xc_dom_* in a big sweep instead of piecemeal. In any case I haven't
waited for a resubmit.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel