Re: [Xen-devel] [PATCH v7 18/21] libxlu: record location when parsing values

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-03-11 at 15:16 +0000, Wei Liu wrote:
> On Wed, Mar 11, 2015 at 03:12:49PM +0000, Ian Campbell wrote:
> > On Mon, 2015-03-09 at 12:51 +0000, Wei Liu wrote:
> > > Originally only setting has line number recorded. Since we're moving to
> > > more sophisticated API, record the location for individual value. It is
> > > useful for error reporting.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> > I'm leaving this one to Ian.
> > 
> > Do we need to rerun something (bison/flex?) on commit?
> > 
> 
> These commits already contains bison / flex outputs. I used Wheezy's
> flex and bison.
> 
> I can exclude them from the patch if necessary.

Since you've got the right versions and the diff is small I think we can
live with them there. I think my precommit scripts will force a regen,
which would highlight if there was any skew.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel