Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2015-03-11 at 15:23 +0000, Wei Liu wrote:
> On Wed, Mar 11, 2015 at 03:13:33PM +0000, Dario Faggioli wrote:
> > On Wed, 2015-03-11 at 15:04 +0000, Wei Liu wrote:

> > > Since we haven't explicitly defined any return value in xl manpage, I
> > > think we should use EXIT_SUCCESS and EXIT_FAILURE per exit(3). 
> > >
> > I like the idea.
> > 
> > > They are
> > > more appropriate then 0 and 1.
> > > 
> > Indeed. However, as far as this patch is concerned, what should I do?
> > 
> >  b) keep it, we'll convert the 0/1 to EXIT_SUCCESS/FAILURE in later
> >     patch(es)

> > ?
> > 
> > My opinion, I don't like c), so I'd go for either a) or b), with a
> > slight preference for b).
> > 
> 
> I think b) is good.
> 
Right. It was the only comment you made on this patch... does that means
I can stick your Acked/Reviewed -by tag to it when sending v2?

Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel