Re: [Xen-devel] [PATCH OSSTEST 03/12] osstest migrate support check catch -> variables

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-02-09 at 11:09 +0000, Wei Liu wrote:
> From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

I remember the f2f discussion around this, but I cannot remember what
this is actually supposed to do. Can you? If so could you write it down
please ;-)

> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  sg-run-job | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sg-run-job b/sg-run-job
> index 2cf810a..cc2ab3b 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -289,7 +289,9 @@ proc run-job/test-pair {} {
>  }
>  
>  proc test-guest-migr {g} {
> -    if {[catch { run-ts . = ts-migrate-support-check + host $g }]} return
> +    set to_reap [spawn-ts . = ts-migrate-support-check + host $g]
> +    set can_migrate [reap-ts $to_reap]
> +    if {!$can_migrate} return
>  
>      foreach iteration {{} .2} {
>          run-ts . =$iteration ts-guest-saverestore + host $g



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel