Re: [Xen-devel] [PATCH OSSTEST 09/12] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-02-09 at 11:10 +0000, Wei Liu wrote:
> Libvirt's configuration converter doesn't know how to deal with BIOS
> selection. The end result is it always use the default one (seabios).

Even with qemu-trad? Does it not use rombios in that case?

> Stub out ovmf and rombios to avoid false positive results.
> 
> This restriction will be removed once libvirt's converter knows how to
> deal with BIOS selection.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  ts-debian-hvm-install | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
> index 449b96c..7fe9ca8 100755
> --- a/ts-debian-hvm-install
> +++ b/ts-debian-hvm-install
> @@ -28,6 +28,13 @@ if (@ARGV && $ARGV[0] =~ m/^--stage(\d+)$/) { $stage=$1; 
> shift @ARGV; }
>  
>  defined($r{bios}) or die "Need to define which bios to use";
>  
> +# Libvirt doesn't know anything about bios. It will always use the
> +# default one (seabios). Stub out rombios and ovmf to avoid false
> +# positive results.
> +if ($r{bios} =~ m/ovmf|rombios/ && $r{toolstack} eq 'libvirt') {
> +    die "libvirt + $r{bios} is not supported yet.";
> +}
> +
>  our ($whhost,$gn) = @ARGV;
>  $whhost ||= 'host';
>  $gn ||= 'debianhvm';



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel