Re: [Xen-devel] [PATCH OSSTEST 12/12] make-flight, mfi-common: create live migration test for libvirt

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-02-09 at 11:10 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  make-flight | 13 +++++++++++--
>  mfi-common  |  6 +++++-
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/make-flight b/make-flight
> index 23d51ea..80c9c39 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -419,11 +419,20 @@ test_matrix_do_one () {
>    done # qemuu_suffix
>  
>    # Test live migration
> -  job_create_test test-$xenarch$kern-$dom0arch-pair test-pair \
> -            $pairtoolstack $xenarch $dom0arch \
> +  for toolstack in $pairtoolstack; do
> +    # Don't change test case name for old test cases with xl and xend
> +    if [ x$toolstack = xxl -o x$toolstack = xxend ]; then
> +      toolstack_suffix=""
> +    else
> +      toolstack_suffix="-$toolstack"
> +    fi
> +    job_create_test test-$xenarch$kern-$dom0arch$toolstack_suffix-pair \

toolstack_suffix doesn't need {} around it, does it? I think not since
"-" is not valid in a shell var, but wanted to check.

Assuming I'm right that it doesn't:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel