Re: [Xen-devel] [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

[Bjorn Helgaas <bhelgaas@xxxxxxxxxx>]

On Mon, Mar 09, 2015 at 10:34:01AM +0800, Yijing Wang wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Use pci_scan_root_bus() instead of deprecated function
> pci_scan_bus_parented().
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> CC: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
>  drivers/pci/xen-pcifront.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index b1ffebe..9e7c28b 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -21,6 +21,7 @@
>  #include <linux/bitops.h>
>  #include <linux/time.h>
>  #include <xen/platform_pci.h>
> +#include "pci.h"
>  
>  #include <asm/xen/swiotlb-xen.h>
>  #define INVALID_GRANT_REF (0)
> @@ -446,6 +447,7 @@ static int pcifront_scan_root(struct pcifront_device 
> *pdev,
>                                unsigned int domain, unsigned int bus)
>  {
>       struct pci_bus *b;
> +     LIST_HEAD(resources);
>       struct pcifront_sd *sd = NULL;
>       struct pci_bus_entry *bus_entry = NULL;
>       int err = 0;
> @@ -470,17 +472,21 @@ static int pcifront_scan_root(struct pcifront_device 
> *pdev,
>               err = -ENOMEM;
>               goto err_out;
>       }
> +     pci_add_resource(&resources, &ioport_resource);
> +     pci_add_resource(&resources, &iomem_resource);
> +     pci_add_resource(&resources, &busn_resource);

Since I don't want to export busn_resource, you might have to allocate your
own struct resource for it here.  And, of course, figure out the details of
which PCI domain you're in and whether you need to share one struct
resource across several host bridges in the same domain.

>       pcifront_init_sd(sd, domain, bus, pdev);
>  
>       pci_lock_rescan_remove();
>  
> -     b = pci_scan_bus_parented(&pdev->xdev->dev, bus,
> -                               &pcifront_bus_ops, sd);
> +     b = pci_scan_root_bus(&pdev->xdev->dev, bus,
> +                               &pcifront_bus_ops, sd, &resources);
>       if (!b) {
>               dev_err(&pdev->xdev->dev,
>                       "Error creating PCI Frontend Bus!\n");
>               err = -ENOMEM;
>               pci_unlock_rescan_remove();
> +             pci_free_resource_list(&resources);
>               goto err_out;
>       }
>  
> @@ -488,7 +494,7 @@ static int pcifront_scan_root(struct pcifront_device 
> *pdev,
>  
>       list_add(&bus_entry->list, &pdev->root_buses);
>  
> -     /* pci_scan_bus_parented skips devices which do not have a have
> +     /* pci_scan_root_bus skips devices which do not have a
>       * devfn==0. The pcifront_scan_bus enumerates all devfn. */
>       err = pcifront_scan_bus(pdev, domain, bus, b);
>  
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel