Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-03-12 at 13:25 +0000, Julien Grall wrote:
> On 12/03/15 13:18, Tamas K Lengyel wrote:
> >     > +    struct radix_tree_root mem_access_settings;
> >     >  };
> >     >
> >     >  /* List of possible type for each page in the p2m entry.
> >     > @@ -217,6 +230,26 @@ static inline int get_page_and_type(struct 
> > page_info *page,
> >     >  /* get host p2m table */
> >     >  #define p2m_get_hostp2m(d) (&(d)->arch.p2m)
> >     >
> >     > +/* mem_event and mem_access are supported on any ARM guest */
> >     > +static inline bool_t p2m_mem_access_sanity_check(struct domain *d)
> >     > +{
> >     > +    return 1;
> >     > +}
> >     > +
> >     > +static inline bool_t p2m_mem_event_sanity_check(struct domain *d)
> >     > +{
> >     > +    return 1;
> >     > +}
> >     > +
> >     > +/* Get access type for a pfn
> >     > + * If pfn == -1ul, gets the default access type */
> > 
> >     Ditto
> > 
> > 
> > Ack, however, all other comments here followed this style even for
> > multi-line comments. If I change the style only on my comments it will
> > be mixed (and ugly) IMHO.
> 
> Hmmm... right. Ian, Stefano, any comments?

Follow the existing style in the file.

> 
> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel