Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Mar 11, Ian Campbell wrote:

> On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > +                                   libxl_vscsi_dev *dev);
> > +int libxl_device_vscsi_get_host(libxl_ctx *ctx,
> > +                                uint32_t domid,
> > +                                const char *cfg,
> > +                                libxl_device_vscsi **vscsi_host);
> What do these two non-standard functions do?
> In general the caller would be expected to provide a libxl_device_vscsi,
> which will be filled in, rather than having the function allocate one.

Is it OK if the caller allocates libxl_device_vscsi, but libxl does
further allocations for the number of libxl_vscsi_dev?

Related: I see libxl_device_vscsi_dispose does now a pointer check, so I
assume its required to validate input in libxl_device_vscsi_get_host.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel