[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] iommu VT-d: separate rmrr addition function



>>> On 12.03.15 at 21:48, <elena.ufimtseva@xxxxxxxxxx> wrote:
> On Wed, Mar 11, 2015 at 10:29:54AM +0000, Jan Beulich wrote:
>> >>> On 09.03.15 at 15:42, <elena.ufimtseva@xxxxxxxxxx> wrote:
>> > --- a/xen/drivers/passthrough/vtd/dmar.c
>> > +++ b/xen/drivers/passthrough/vtd/dmar.c
>> > @@ -567,6 +567,66 @@ out:
>> >      return ret;
>> >  }
>> >  
>> > +int register_one_rmrr(struct acpi_rmrr_unit *rmrru)
>> 
>> static - I don't see why the command line processing in patch 2 can't
>> be put in this file.
> 
> I wanted to keep it close to iommu command line parser in iommu.c.
> Andrew mentioned that the parser should be defined as custom_param.
> Did you mean that as well and that it should be moved to dmar.c?

Yes and yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.