Re: [Xen-devel] [PATCH 1/2] x86: identifying the boot cpu

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/13/2015 06:16 PM, Andrew Cooper wrote:
> Please use git-send-email and thread your patch series properly.  You
> are still submitting 3 independent emails.
> 
> On 13/03/15 18:07, Uma Sharma wrote:
>> Provide helpers to access the socket and core IDs, resulting from
>> identification phase.
>> Initialize socket and core ID to -1 i.e invalid instead of 0. Having
>> that field in all elements set to 0 would induce credit2 to think that
>> the pCPU have already been initialized, and that all are on socket 0
>> in case of credit2 socket scheduler and on core 0 in case of credit2
>> core scheduler.
>>
>> Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>
> 
> You have not addressed the cpu onlining/offlining problem which Jan
> asked you about.
> 
> Furthermore, you don't make any justification as to why it is safe to
> change the defaults under all the other users of cpu_data.

That's because Dario said these were his patches and that he would be
doing the revision based on comments.

That said, Uma, if it was your intention not to actually suggest this be
accepted now, then you probably should have put "RFC" in the subject
line, and mentioned that this is a patch that Dario is going to work on
a replacement for, so that people know not to review it.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel