Re: [Xen-devel] [RFC PATCH 02/19] xen/arm: its: Import GICv3 ITS driver from linux

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 16 Mar 2015, Vijay Kilari wrote:
> On Fri, Mar 13, 2015 at 4:05 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> >
> >
> > On 13/03/2015 10:24, Julien Grall wrote:
> >>
> >> Hello Vijay,
> >>
> >> On 02/03/2015 12:30, vijay.kilari@xxxxxxxxx wrote:
> >>>
> >>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>>
> >>> This is actual GICv3 ITS driver from linux.
> >>> No xen related changes are made and is not compiled.
> >>>
> >>> This helps to import any issues found in linux
> >>
> >>
> >> Can you provide the commit ID you used to pick the file?
> >>
> >> AFAICT there is at least one bug fix in upstream which may be necessary
> >> for us [1]
> >>
> >> [1] c848126734e8621e81659d819922b20d93a2aa6d
> 
> This patch has changes in its_create_device() is not used.
> 
> BTW, I am using 3.18 kernel. Can I pull latest ITS driver from 4.0 and
> use it?

Yep


> >
> > BTW this is not even a copy from Linux. You replaced all the hard tab by
> > space...
> 
> Yes, I replaced tabs. Whats the ways of copying linux driver to Xen.
> Should we keep and maintain coding style as well?

If it is the Linux driver you are importing, then it might be worth
trying to keep it as close to the original as possible so that it won't
be too hard to update in the future. Like Julien has done for the SMMU
driver.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel