[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/4] x86/MSI-X: access MSIâX table only after having enabled MSIâX
>>> On 13.03.15 at 20:18, <andrew.cooper3@xxxxxxxxxx> wrote: > On 10/03/15 16:28, Jan Beulich wrote: >> As done in Linux by f598282f51 ("PCI: Fix the NIU MSI-X problem in a >> better way") and its broken predecessor, make sure we don't access the >> MSI-X table without having enabled MSI-X first, using the mask-all flag >> instead to prevent interrupts from occurring. >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > General quarms of this series aside, Reviewed-by: Andrew Cooper > <andrew.cooper3@xxxxxxxxxx> > > There is a spurious whitespace change and a spurious comment change > which you perhaps didn't mean to include. I was able to find the former, but I don't see the latter. There two comment changes in total: In one case, a "fall through" one gets intentionally dropped, and in the other the comment gets extended quite a bit, again intentionally. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |