Re: [Xen-devel] [RFC PATCH 02/19] xen/arm: its: Import GICv3 ITS driver from linux

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Mon, Mar 16, 2015 at 6:45 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Vijay,
>
> On 16/03/15 09:55, Vijay Kilari wrote:
>> On Fri, Mar 13, 2015 at 4:05 PM, Julien Grall <julien.grall@xxxxxxxxxx> 
>> wrote:
>>>
>>>
>>> On 13/03/2015 10:24, Julien Grall wrote:
>>>>
>>>> Hello Vijay,
>>>>
>>>> On 02/03/2015 12:30, vijay.kilari@xxxxxxxxx wrote:
>>>>>
>>>>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>>>>
>>>>> This is actual GICv3 ITS driver from linux.
>>>>> No xen related changes are made and is not compiled.
>>>>>
>>>>> This helps to import any issues found in linux
>>>>
>>>>
>>>> Can you provide the commit ID you used to pick the file?
>>>>
>>>> AFAICT there is at least one bug fix in upstream which may be necessary
>>>> for us [1]
>>>>
>>>> [1] c848126734e8621e81659d819922b20d93a2aa6d
>>
>> This patch has changes in its_create_device() is not used.
>
> But you are modifying its_create_device in patch #2 in order to make the
> code compile.
>
> It's really hard to follow what is necessary or not from the real driver.
>
> Looking to this function, it seems to be very useful in order to track
> which ITS is associated to the device.

Just to make it compile I kept this function in patch#2
In patch#4 "xen/arm: its: Remove unused code in ITS driver"
this code is removed.

First we can remove unused code and later make it compile in next patch.
But that make changes are not incremental fashion.

The vits_its_add_device() in vITS driver will track the devices
added to the domain.

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel