Re: [Xen-devel] [PATCH v2 3/3] xen: arm: handle PCI DT node ranges and interrupt-map properties

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-16 at 16:38 +0000, Julien Grall wrote:
> On 16/03/15 16:22, Ian Campbell wrote:
> >>> +    if ( dt_device_type_is_equal(dev, "pci") )
> >>> +        return map_pci_device_ranges(d, dev, ranges, len);
> >>> +
> >>> +    printk("Cannot handle ranges for non-PCI device %s type %s\n",
> >>> +           dt_node_name(dev), dev->type);
> >>> +
> >>
> >> Is the printk really necessary? It will a spurious log on platform where
> >> ranges is not empty (midway, arndale, foundation model...).
> > 
> > If the ranges is present and non-empty it's not impossible that we need
> > to be doing something with it. I'd rather try and figure out how to
> > whitelist such nodes, perhaps they lack a dev_type completely?
> 
> Why would we compute the range? Any usable MMIO should be describe the
> child.
> 
> We have to compute the ranges for PCI because we want to map everything
> at boot time and the PCI devices are not discoverable via the device tree...

The same would be true for any similar discoverable bus.

Which I suppose is uncommon on ARM. I think I'll make this a debug level
print, or even a #if DT_DEBUG. (Same for the interrupt case)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel