Re: [Xen-devel] [PATCH 2/7] xen: sched_rt: implement the .free_pdata hook

[Meng Xu <xumengpanda@xxxxxxxxx>]

Hi Dario,

2015-03-16 13:10 GMT-04:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:
> On Mon, 2015-03-16 at 18:04 +0100, Dario Faggioli wrote:
>> which is called by cpu_schedule_down(), and is necessary
>> for resetting the spinlock pointers in schedule_data from
>> the RTDS global runqueue lock, back to the default _lock
>> fields in the struct.

I noticed this issue the day before yesterday (last weekend) as well
and fixed it in my local repository:
https://github.com/PennPanda/xenproject/blob/rtds/nooh/v3/xen/common/sched_rt.c
from line 522 to 537.

Thank you very much for pointing it out! :-)

>>
>> Not doing so causes Xen to explode, e.g., when removing
>> pCPUs from an RTDS cpupool and assigning them to another
>> one.
>>
> Hey Meng,
>
> We discussed about this issue before, here:
> http://lists.xen.org/archives/html/xen-devel/2014-09/msg02765.html
>
> But, as far as it looks, the code we ended up merging still had the
> issue (i.e., it did not have the hook implemented)!
>
> I was working a bit on/off (for family reasons) in that period, so I
> can't really tell how that happened. :-/
> Not a big deal... this code is marked as experimental for a reason, but
> it probably make sense to double check that anything else similar
> happened, can you do that?


Sure! I will review that problem, do the double check and let you know
the result!

>
> Thanks and Regards,

Thank you very much for doing this!

Best,

Meng

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel