Re: [Xen-devel] [PATCH 3/7] xen: rework locking for dump of scheduler info (debug-key r)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.03.15 at 12:14, <dario.faggioli@xxxxxxxxxx> wrote:
> On Tue, 2015-03-17 at 10:54 +0000, Jan Beulich wrote:
>> Finally, as said in different contexts earlier, I think unconditionally
>> acquiring locks in dumping routines isn't the best practice. At least
>> in non-debug builds I think these should be try-locks only, skipping
>> the dumping when a lock is busy.
>> 
> That makes sense. It also looks, if not completely orthogonal, something
> that can be done in a follow-up patch wrt this series. I.e., we first
> move the locking logic where it belongs, and then we rework it toward
> using _trylock(), does this make sense?

Sure, the order doesn't matter all that much. And the keyhandler
issue is certainly affecting code elsewhere too, so getting this
improved would presumably not be part of a scheduler specific
patch series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel