Re: [Xen-devel] [PATCH 2/3] tools/libxl/libxl_cpuid.c: Fix leak of resstr on error path

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-17 at 15:44 +0000, Wei Liu wrote:
> On Mon, Mar 16, 2015 at 10:06:17AM +0000, PRAMOD DEVENDRA wrote:
> > From: Pramod Devendra <pramod.devendra@xxxxxxxxxx>
> > 
> > Signed-off-by: Pramod Devendra <pramod.devendra@xxxxxxxxxx>
> > CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Applied.

> >      resstr = entry->policy[flag->reg - 1];
> > -    if (resstr == NULL) {
> > -        resstr = strdup("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx");
> > -    }
> 
> Minor nit. I would prefer "resstr = " be grouped with the code you
> moved. No need to resend though.

Do you mean the restr = entry->... bit?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel