Re: [Xen-devel] [PATCH 14/14] libxl: Fix do_memory_op to return negative value on errors

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote:
> instead of the -Exx values (which should go in errno).
> 
> This patch has HUGE implications.

For such a small patch!

>  There is a lot of APIs
> that are using do_memory_op. Fortunatly most of them

"Fortunately".

> check for 'if (do_memory_op(..) < 0)' so will function
> properly. However there were some which printed the return
> value to the user. They have been fixed in:
> 
>  libxl: Don't assign return value to errno for E820 get/set xc_ calls.
>  libxl: Check xc_sharing_* for proper return values.
>  libxl: Print xc_domain_decrease_reservation proper errno value.
>  libxl: If xc_domain_add_to_physmap fails, include errno value
>  libxl: Check xc_maximum_ram_page for negative return values.
>  libxl: Check xc_domain_maximum_gpfn for negative return values

s/libxl/libxc/ in most of them.

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxc/xc_private.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c
> index 0735e23..1222d05 100644
> --- a/tools/libxc/xc_private.c
> +++ b/tools/libxc/xc_private.c
> @@ -516,7 +516,7 @@ int do_memory_op(xc_interface *xch, int cmd, void *arg, 
> size_t len)
>  {
>      DECLARE_HYPERCALL;
>      DECLARE_HYPERCALL_BOUNCE(arg, len, XC_HYPERCALL_BUFFER_BOUNCE_BOTH);
> -    long ret = -EINVAL;
> +    long ret = -1;
>  
>      if ( xc_hypercall_bounce_pre(xch, arg) )
>      {



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel