Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

[Jim Fehlig <jfehlig@xxxxxxxx>]

Ian Campbell wrote:
> On Tue, 2015-03-17 at 17:34 +0000, Wei Liu wrote:
>   
>> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote:
>>     
>>> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>>>
>>> Unlock the userdata before we actually call xc_domain_destroy.  This
>>> leaves open the possibility that other libxl callers will see the
>>> half-destroyed domain (with no devices, paused), but this is fine.
>>>
>>> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> Reviewed-by: Jim Fehlig <jfehlig@xxxxxxxx>
>>> Tested-by: Jim Fehlig <jfehlig@xxxxxxxx>
>>>       
>> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>     
>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> I'm not sure if this is safe/sensible to apply without the preceding
> patch which I had a comment on.
>   

It is not so sensible without the subsequent patch 3/3.  This patch is
not related to the preceding patch 1/3.

Regards,
Jim

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel