Re: [Xen-devel] Regression introduced by libxlu: rework internal representation of setting

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 18, 2015 at 04:18:32PM -0400, Konrad Rzeszutek Wilk wrote:
> Hey
> 
> The git commit 1a09c5113a38dcf1fb6582d77285d727defeea6c
> "libxlu: rework internal representation of setting" breaks build:
> 
> ~/xtt-x86_64/xen/tools/libxl> make
> rm -f _paths.h.tmp;  echo "#define SBINDIR \"/usr/sbin\"" >>_paths.h.tmp;  
> echo "#define BINDIR \"/usr/bin\"" >>_paths.h.tmp;  echo "#define LIBEXEC 
> \"/usr/lib/xen\"" >>_paths.h.tmp;  echo "#define LIBEXEC_BIN 
> \"/usr/lib/xen/bin\"" >>_paths.h.tmp;  echo "#define LIBDIR \"/usr/lib\"" 
> >>_paths.h.tmp;  echo "#define SHAREDIR \"/usr/share\"" >>_paths.h.tmp;  echo 
> "#define XENFIRMWAREDIR \"/usr/lib/xen/boot\"" >>_paths.h.tmp;  echo "#define 
> XEN_CONFIG_DIR \"/etc/xen\"" >>_paths.h.tmp;  echo "#define XEN_SCRIPT_DIR 
> \"/etc/xen/scripts\"" >>_paths.h.tmp;  echo "#define XEN_LOCK_DIR 
> \"/var/lock\"" >>_paths.h.tmp;  echo "#define XEN_RUN_DIR \"/var/run/xen\"" 
> >>_paths.h.tmp;  echo "#define XEN_PAGING_DIR \"/var/lib/xen/xenpaging\"" 
> >>_paths.h.tmp;  if ! cmp -s _paths.h.tmp _paths.h; then mv -f _paths.h.tmp 
> _paths.h; else rm -f _paths.h.tmp; fi
> gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 
> -Wall -Wstrict-prototypes -Wdeclaration-after-statement 
> -Wno-unused-but-set-variable   -O0 -g3 -D__XEN_TOOLS__ -MMD -MF 
> .libxlu_cfg_y.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
> -fno-optimize-sibling-calls  -Werror -Wno-format-zero-length 
> -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral 
> -I. -fPIC -pthread 
> -I/home/konrad/ssd/konrad/xtt-x86_64/bootstrap/xen-unstable/tools/libxl/../../tools/libxc/include
>  
> -I/home/konrad/ssd/konrad/xtt-x86_64/bootstrap/xen-unstable/tools/libxl/../../tools/include
>    -c -o libxlu_cfg_y.o libxlu_cfg_y.c 
> In file included from libxlu_cfg_i.h:23,
>                  from libxlu_cfg_y.y:22:
> libxlu_internal.h:39: error: redefinition of typedef âXLU_ConfigListâ
> libxlutil.h:25: note: previous declaration of âXLU_ConfigListâ was here
> make: *** [libxlu_cfg_y.o] Error 1
> FC-64 <konrad@build-external:~/xtt-x86_64/xen/tools/libxl> 
> FC-64 <konrad@build-external:~/xtt-x86_64/xen/tools/libxl> git log --oneline 
> | head -1
> 1a09c51 libxlu: rework internal representation of setting
> FC-64 <konrad@build-external:~/xtt-x86_64/xen/tools/libxl> git checkout HEAD^
> Previous HEAD position was 1a09c51... libxlu: rework internal representation 
> of setting
> HEAD is now at 711dec6... libxl: define LIBXL_HAVE_VNUMA
> FC-64 <konrad@build-external:~/xtt-x86_64/xen/tools/libxl> git clean -f -x 
> 1>/dev/null
> FC-64 <konrad@build-external:~/xtt-x86_64/xen/tools/libxl> make 1>/dev/null
> Parsing libxl_types.idl
> Parsing libxl_types_internal.idl
> Parsing libxl_types.idl
> 
> This is under Fedora Core 13.

Wow, this is really old release.

I think some older gccs (<= 4.5 IIRC) don't like multiple definitions. I
will send a patch to fix it.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel