[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 21/33] xen/passthrough: Introduce iommu_construct
>>> On 19.03.15 at 20:29, <julien.grall@xxxxxxxxxx> wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -187,6 +187,32 @@ void iommu_teardown(struct domain *d) > tasklet_schedule(&iommu_pt_cleanup_tasklet); > } > > +int iommu_construct(struct domain *d) > +{ > + int rc = 0; > + > + if ( need_iommu(d) > 0 ) > + return 0; > + > + if ( !iommu_use_hap_pt(d) ) > + { > + rc = arch_iommu_populate_page_table(d); > + if ( rc ) > + return rc; > + } Please limit the scope of rc to the body of this if(). With that Acked-by: Jan Beulich <jbeulich@xxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |