Re: [Xen-devel] [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-03-20 at 10:00 -0400, Boris Ostrovsky wrote:
> On 03/20/2015 09:25 AM, Ian Campbell wrote:
> > On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote:
> > [...]
> >> * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid 
> >> type
> >>    (core, socket, node).
> > But not for distance:
> >
> >> @@ -1375,7 +1360,7 @@ static PyObject *pyxc_numainfo(XcObject *self)
> >>           for ( j = 0; j <= max_node_index; j++ )
> >>           {
> >>               uint32_t dist = nodes_dist[i*(max_node_index+1) + j];
> >> -            if ( dist == INVALID_TOPOLOGY_ID )
> >> +            if ( dist == ~0u )
> > ?
> 
> This patch replaces INVALID_TOPOLOGY_ID with 
> XEN_INVALID_CORE/SOCKET/NODE_ID for CPU topology. Neither of those would 
> be appropriate for distance.

Right, I was asking for INVALID_DIST, but...
[...]
> The next patch (4/8) introduces XEN_INVALID_NODE_DIST

You already did it!

So, Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(you may as well mention in the commit log next time too)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel