[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 0/8] Display IO topology when PXM data is available (plus some cleanup)


On 19/03/15 21:53, Boris Ostrovsky wrote:
> A few patches that add interface for querying hypervisor about device
> topology and allow 'xl info -n' display this information if PXM object
> is provided by ACPI.
> This series also makes some optimizations and cleanup of current CPU
> topology and NUMA sysctl queries.

I saw that some of these patches was pushed upstream last week. It
actually breaks compilation on ARM.

While the first error is trivial to fix (it's a missing include
xen/numa.h in xen/pci.h ). The second one is more difficult

sysctl.c: In function ‘do_sysctl’:
sysctl.c:349:42: error: ‘BAD_APICID’ undeclared (first use in this function)
                     if ( cputopo.core == BAD_APICID )
The value BAD_APICID doesn't have any meaning on ARM. Therefore the
usage in common code looks wrong to me. I'm not sure what should be the
testing value here given that cpu_to_core is not yet correctly
implemented on ARM.

It would be nice to at least build test it ARM/ARM64 before pushing
patches which modify common code.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.