Re: [Xen-devel] [PATCH 2/2] x86/vMSI-X: add valid bits for read acceleration

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.03.15 at 20:11, <konrad.wilk@xxxxxxxxxx> wrote:
> On Fri, Mar 20, 2015 at 04:27:57PM +0000, Jan Beulich wrote:
>> Again because Xen doesn't get to see all guest writes, it shouldn't
>> serve reads from its cache before having seen a write to the respective
>> address.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
>> 
>> --- a/xen/arch/x86/hvm/vmsi.c
>> +++ b/xen/arch/x86/hvm/vmsi.c
>> @@ -153,12 +153,15 @@ struct msixtbl_entry
>>      /* TODO: resolve the potential race by destruction of pdev */
>>      struct pci_dev *pdev;
>>      unsigned long gtable;       /* gpa of msix table */
>> -    unsigned long table_flags[BITS_TO_LONGS(MAX_MSIX_TABLE_ENTRIES)];
>> +    DECLARE_BITMAP(table_flags, MAX_MSIX_TABLE_ENTRIES);
> 
> That seems unrelated to this patch? Perhaps mention the cleanup
> part in the commit.

Ah, yes, I meant to but forgot.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel