Re: [Xen-devel] [PATCH 04/29] libxl: suspend: common suspend callbacks take rc

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> Change the following functions to take a libxl error code rather than
> a boolean "ok" value, and translate that value to the boolean expected
> by libxc at the last moment:
>   domain_suspend_callback_common_done        } dss->callback_common_done
>   remus_domain_suspend_callback_common_done  }
>   domain_suspend_common_done
> 
> Also, abolish domain_suspend_common_failed as
> domain_suspend_common_done can easily do its job and the call sites
> now have to supply the right rc value anyway.
> 
> In domain_suspend_common_guest_suspended, change "ret" to "rc"
> as it contains a libxl error code.
> 
> There is no functional change in this patch: the proper rc value now
> propagates further, but is still eventually smashed to a boolean.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

There are a few new ERROR_FAILs which we might like to consider making
more specific either now or later.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel