Re: [Xen-devel] [PATCH 12/29] libxl: events: Permit timeouts to signal cancellation

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> The callback functions provided by users must take an rc value.  This
> rc value can be ERROR_TIMEDOUT or ERROR_CANCELLED.
> 
> Users of xswait are now expected to deal correctly with
> ERROR_CANCELLED.  If they experience this, it hasn't been logged.
> And the caller won't log it either since it's not TIMEDOUT.
> Luckily this is correct, so we can just change the doc comment.
> 
> Currently nothing generates ERROR_CANCELLED; in particular the
> timeouts cannot in fact signal cancellation.
> 
> There should be no publicly visible change except that some error
> returns from libxl will change from ERROR_FAIL to ERROR_TIMEDOUT, and
> some changes to debugging messages.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel