Re: [Xen-devel] [PATCH 17/29] libxl: cancellation: Provide public ao cancellation API

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote:
> +/*
> + * It is sometimes possible to cancel an asynchronous operation.
> + *
> + * libxl_ao_cancel searches for an ongoing asynchronous operation whose
> + * ao_how is identical to *how, and tries to cancel it.

I can see that you have arranged for the pointer not to be required to
match, just the contents of the struct, which may be convenient for some
callers who haven't remembered the ao_how somewhere convenient, but is
it permissible to use the same pointer if it is convenient?

Other than wondering about that this patch looks good,
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel