Re: [Xen-devel] [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for PV guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 03/24/2015 10:28 AM, Jan Beulich wrote:
> > > > On 17.03.15 at 15:54, <boris.ostrovsky@xxxxxxxxxx> wrote:
> > Changes in v19:
> > * Adjusted for new ops interfaces (passing vcpu vs. vpmu)
> > * Test for domain->max_cpu in choose_hwdom_vcpu() instead of
> > 'domain->vcpu!=NULL'
> I suppose that's something that then should also be done in patch 7?
We only need this routine during interrupt handling (for PV(H)) and this 
is the patch that introduces this functionality.
And if you are asking about the test specifically --- this is also the 
first patch where we refer to hardware_domain->vcpu[], which is what the 
test is really for.
Or is it something else that you had in mind?

> > +    vpmu = vcpu_vpmu(curr);
> >   
> >       vpmu->hw_lapic_lvtpc = PMU_APIC_VECTOR | (val & APIC_LVT_MASKED);
> > -    apic_write(APIC_LVTPC, vpmu->hw_lapic_lvtpc);
> > +
> > +    /* Postpone APIC updates for PV(H) guests if PMU interrupt is pending */
> > +    if ( is_hvm_vcpu(curr) || !vpmu->xenpmu_data ||
> Here and below you use is_hvm_vcpu() - is the title wrongly saying
> just PV when PV/PVH is meant?
Yes, it should include both PV and PVH.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel