Re: [Xen-devel] [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-24 at 16:53 +0000, Ian Campbell wrote:
> On Tue, 2015-03-24 at 14:49 +0000, Wei Liu wrote:
> > On Tue, Mar 24, 2015 at 02:32:42PM +0000, Ian Campbell wrote:
> > > On Fri, 2015-03-20 at 16:19 +0000, Wei Liu wrote:
> > > > +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t 
> > > > dm_domid,
> > > > +                                          uint32_t domid,
> > > > +                                          const char *format,  ...);
> > > 
> > > This should have the PRINTF_ATTRIBUTE thing and not the double space
> > > before "...".
> > > 
> > > With that fixed: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > 
> > > Since this is pretty minor if you want to resend just this one patch, or
> > > even send an incremental fixup to be folded in I can take care of it on
> > > commit.
> > > 
> > 
> > Here is an incremental fix.
> 
> Thanks, I folded that in and pushed the first 4 patches in this series.
> 
> The final patch (Revert "x86/hvm: wait for at least one ioreq server to
> be enabled") needs an x86 ack which it currently lacks so I've left this
> for now (Jan, I guess you'll pick it up or ask me to do so once you've
> acked it)

Jan: Note that patch 4/5 got reverted, so patch 5 (the revert quoted
above) shouldn't go in just yet.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel