Re: [Xen-devel] [PATCH v2 1/2] iommu VT-d: separate rmrr addition function

[Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>]

On Wed, Mar 25, 2015 at 05:04:38PM +0000, Jan Beulich wrote:
> >>> On 24.03.15 at 17:08, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > +static int register_one_rmrr(struct acpi_rmrr_unit *rmrru)
> > +{
> > +    bool_t ignore = 0;
> > +    unsigned int i = 0;
> > +    int ret = 0;
> > +
> > +    /* Skip checking if segment is not accessible yet. */
> > +    if ( !pci_known_segment(rmrru->segment) )
> > +        i = UINT_MAX;
> > +
> > +    for ( ; i < rmrru->scope.devices_cnt; i++ )
> > +    {
> > +        u8 b, d, f;
> > +
> > +        b = d = f = 0;
> 
> ???
> 
> > +        b = PCI_BUS(rmrru->scope.devices[i]);
> > +        d = PCI_SLOT(rmrru->scope.devices[i]);
> > +        f = PCI_FUNC(rmrru->scope.devices[i]);
> 
> Quoting my reply on v1: "Please make this the declarations (with
> initializers) of these variables; they don't appear to be used outside
> this scope." I.e.
> 
> u8 b = PCI_BUS(...);

Got it, I did read it differently first time. Example helps for sure!

> 
> > +    if ( !ret && (rmrru->scope.devices_cnt != 0) )
> > +        ret = register_one_rmrr(rmrru);
> > +        if ( ret )
> >              xfree(rmrru);
> 
> Indentation is screwed up here.

Ok, will fix.

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel