Re: [Xen-devel] [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

["Jaggi, Manish" <Manish.Jaggi@xxxxxxxxxxxxxxxxxx>]

Regards,
Manish Jaggi

________________________________________
From: Julien Grall <julien.grall@xxxxxxxxxx>
Sent: Friday, March 27, 2015 6:32 PM
To: Jaggi, Manish; Xen Devel; Prasun.kapoor@xxxxxxxxxx; Kumar, Vijaya; Ian 
Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, 
domain_iommu_info

Hi Manish,

On 27/03/15 07:22, Manish Jaggi wrote:
> The name arm_smmu_xen_domain was mapped to domain_hvm_iommu(d)->arch.priv.
> Also there are a lot of datastructre in smmu.c with name ending in domain

data structure.

> it is not intuitive and code is hard to understand.

Now it's more difficult to differentiate domain_iommu_info and iommu_domain.

[manish] Please see my previous mail. Also please pick any other name there are 
so many data structures which end up in domain. What is the difference between 
arm_smmu_domain and arm_smmu_xen_domain, I cannot find it based on name. 

Regards,

Regards,

--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel