[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] REGRESSION [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values



On Fri, 2015-03-27 at 21:17 +0000, Andrew Cooper wrote:
> > -int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid, xen_pfn_t 
> > *gpfns);
> > +int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid);
> 
> It is perfectly fine for xc_domain_maximum_gpfn() to keep its *gpfn
> pointer, as this is a rather more sane interface which doesn't truncate
> the hypervisor long in a 64bit toolstack.

Ack. FAOD the two interfaces should be:
int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid, xen_pfn_t *gpfns);
int xc_domain_nr_gpfns(xc_interface *xch, domid_t domid, xen_pfn_t *gpfns);

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.