[Xen-devel] XSM build failure in staging

[Wei Liu <wei.liu2@xxxxxxxxxx>]

OSSTest seems to have caught a regression in building XSM.

http://logs.test-lab.xenproject.org/osstest/logs/50263/build-amd64-xsm/5.ts-xen-build.log

hooks.c: In function 'flask_sysctl':
hooks.c:786:10: error: 'XEN_SYSCTL_topologyinfo' undeclared (first use in this 
function)
hooks.c:786:10: note: each undeclared identifier is reported only once for each 
function it appears in
make[5]: *** [hooks.o] Error 1
make[5]: Leaving directory 
`/home/osstest/build.50263.build-amd64-xsm/xen/xen/xsm/flask'
make[4]: Leaving directory 
`/home/osstest/build.50263.build-amd64-xsm/xen/xen/xsm'
make[4]: *** [flask/built_in.o] Error 2
make[3]: *** [/home/osstest/build.50263.build-amd64-xsm/xen/xen/xsm/built_in.o] 
Error 2
make -f /home/osstest/build.50263.build-amd64-xsm/xen/xen/Rules.mk -C acpi 
built_in.o
make[3]: *** Waiting for unfinished jobs....

Looking at recent commits, the following commit seemed to remove
XEN_SYSCTL_topologyinfo.

commit 2090f14c5cbd659c3adebc8cd27d423fae8b6b54
Author: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Date:   Fri Mar 20 17:35:39 2015 +0100

    sysctl: make XEN_SYSCTL_topologyinfo sysctl a little more efficient

    A number of changes to XEN_SYSCTL_topologyinfo interface:

    * Instead of copying data for each field in xen_sysctl_topologyinfo 
separately
      put cpu/socket/node into a single structure and do a single copy for each
      processor.
    * A NULL cputopo handle passed is a request for maximum number of CPUs
      (num_cpus). If cputopo is valid and num_cpus is smaller than the number of
      CPUs in the system then -ENOBUFS is returned (and correct num_cpus is 
provided)
    * Do not use max_cpu_index, which is almost always used for calculating 
number
      CPUs (thus requiring adding or subtracting one), replace it with num_cpus.
    * There is no need to copy whole op in sysctl to user at the end, we only 
need
      num_cpus.
    * Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the 
fact
      that these are used for CPU topology. Subsequent patch will add support 
for
      PCI topology sysctl.
    * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid 
type
      (core, socket, node).

    Update sysctl version to 0x0000000C

    Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel