Re: [Xen-devel] [PATCH v4 14/33] xen/arm: vgic: Correctly calculate GICD_TYPER.ITLinesNumber

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 31/03/15 11:46, Ian Campbell wrote:
> On Thu, 2015-03-19 at 19:29 +0000, Julien Grall wrote:
>> The formula of GICD_TYPER.ITLinesNumber is 32(N + 1).
>>
>> As the number of SPIs suppported by the domain may not be a multiple of
>> 32, we have to round up the number before using it.
>>
>> At the same time remove the mask GICD_TYPE_LINES which is pointless.
> 
> I presume because something else has ensured that nr_spis is less than
> the maximum value represented by the mask?

The number of SPIs is validated in domain_vgic_init.

We would be in trouble in the IRQ guest injection if this number is too
high.

> 
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel