Re: [Xen-devel] [PATCH v2 5/5] xen: sched_rt: print useful affinity info when dumping

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Mon, 2015-03-30 at 14:47 +0100, George Dunlap wrote:
> On 03/17/2015 03:33 PM, Dario Faggioli wrote:

> > Such scratch area can be used to kill most of the
> > cpumasks{_var}_t local variables in other functions
> > in the file, but that is *NOT* done in this chage.
> > 
> > Finally, convert the file to use keyhandler scratch,
> > instead of open coded string buffers.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Cc: Meng Xu <xumengpanda@xxxxxxxxx>
> > Cc: Jan Beulich <JBeulich@xxxxxxxx>
> > Cc: Keir Fraser <keir@xxxxxxx>
> > ---
> > Changes from v1:
> >  * improved changelog;
> >  * made a local variable to point to the correct
> >    scratch mask, as suggested during review.
> 
> Thanks,
> 
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
Thanks to you, but I think this has an issue.

The same one that you spotted in Justin's Credit2 affinity series: the
scratch mask array should not be allocated in rt_init(), or at least not
without checking that it's not there already, or the creation of a new
cpupool with the same scheduler will screw things up.

So, at least this very patch needs a v3. It's pretty independent from
the rest of the series, which should be all acked by now, but I can
resend it all if it's easier/better, just let me know. :-)

Thanks again and Regards,
Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel