Re: [Xen-devel] [libvirt] [PATCH 2/3] libxl: acquire a job when destroying a domain

[Jim Fehlig <jfehlig@xxxxxxxx>]

Martin Kletzander wrote:
> On Thu, Mar 26, 2015 at 03:29:51PM -0600, Jim Fehlig wrote:
>> Konrad Rzeszutek Wilk wrote:
>>> On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:
>>>
>>>> A job should be acquired at the beginning of a domain destroy
>>>> operation,
>>>> not at the end when cleaning up the domain.  Fix two occurances of
>>>> this
>
> And s/occurances/occurrences/ here.
>
> It looks fine, though, with the squash-in.

Thanks.  I've sent a V2 addressing comments from you and Konrad

https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html

>
> Also, if you want to have a look at some other things that might be
> fixed here, plus some speed-up gained, have a look at my commit
> 540c339a, that does some similar things in the QEMU driver.

Ah, that is nice work!  I recall seeing the series and thinking it was
pertinent to the libxl driver, but then forgot to take a closer look. 
Thanks for the reminder!  I'll work on a similar improvement in the
libxl driver.  But IMO that should not hold up this series, which is a
big improvement in itself.

Regards,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel