[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap



Hi Chen,

On 07/04/2015 08:33, Chen Baozi wrote:
From: Chen Baozi <baozich@xxxxxxxxx>

We have already had the boot pagetable when reaching the point
of early_printk fixmap setup. Thus there is no longer necessary
to caculate physical address of xen_fixmap.

s/caculate/calculate/


OOI, is it a bug or a clean up?


Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
---
  xen/arch/arm/arm64/head.S | 1 -
  1 file changed, 1 deletion(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 75b7ee1..a2ac2d4 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -520,7 +520,6 @@ paging:

          /* Add UART to the fixmap table */
          ldr   x1, =xen_fixmap
-        add   x1, x1, x20            /* x1 := paddr (xen_fixmap) */

You need to add a comment on "ldr x1..." in order to explain what x1 contains. i.e /* x1 := vaddr (xen_fixmap) */

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.