Re: [Xen-devel] [PATCH v6 2/5] sysctl: Add sysctl interface for querying PCI topology

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/07/2015 12:09 PM, Andrew Cooper wrote:
> On 06/04/15 23:12, Boris Ostrovsky wrote:
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > ---
> >
> > Changes in v6:
> > * Dropped continuations, the sysctl now returns after 64 iteration if necessary
> Why? The caller should reasonably expect a single hypercall to complete,
> not to have to reissue repeated to get all the data they want.
The caller is expected to restart from first_dev, not from beginning.

> > * -ENODEV returned if device is not found
> You don't actually break on -ENODEV, which causes the loop to continue
> to new devices and leave no hint as to which device doesn't exist.
Doh, I must have lost the break during various merges.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel