Re: [Xen-devel] [PATCH V14 2/7] xen/arm: Implement domain_get_maximum_gpfn

[Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>]

The patch that will use xc_domain_maximum_gpfn is not included right now in this series as my other series significantly cleans up the existing xen-access test code. Before that's merged, there is no point in carrying that patch here as it will be in conflict anyway. I'm intending to send that once my cleanup series is merged (or append it to this series again if it's still open).

Tamas

On Wed, Apr 8, 2015 at 3:23 PM, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:

Hi Tamas,

On 26/03/15 22:05, Tamas K Lengyel wrote:
> From: Julien Grall <julien.grall@xxxxxxxxxx>
>
> The function domain_get_maximum_gpfn is returning the maximum gpfn ever
> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose.
>
> We use this in xenaccess as to avoid the user attempting to set page
> permissions on pages which don't exist for the domain, as a non-arch specific
> sanity check.

FWIW, xc_domain_maximum_gpfn is buggy for ARM64 as a PFN can be encode
with up to 36 bits which doesn't fit on the return code (an int is used).

Although, I don't see any call to xc_domain_maximum_gpfn in memaccess
(tools/tests/memaccess). So is this patch still useful?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel