[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 p2 16/19] tools/libxl: arm: Use an higher value for the GIC phandle



On 09/04/15 18:00, Julien Grall wrote:
> On 09/04/15 17:52, Ian Jackson wrote:
>> Julien Grall writes ("Re: [Xen-devel] [PATCH v5 p2 16/19] tools/libxl: arm: 
>> Use an higher value for the GIC phandle"):
>>> On 09/04/15 17:17, Ian Jackson wrote:
>>> I only expect people using the partial device tree in very specific use
>>> case. Generic use case is not even possible with the current status of
>>> non-PCI (i.e device tree) passthrough. So people control their environment.
>>>
>>> As I said later in patch, supporting dynamic allocation will require
>>> some rework in the device tree creation for the guest.
>>>
>>> So I was suggesting this solution as temporary in order to not block the
>>> DT passthrough.
>>
>> What would happen if our assumption about the DT compiler were
>> violated ?
> 
> The phandle would be present in 2 different nodes of the DT. FYI, that
> may also happen if a user use 2 times the same phandle in the partial DT.
> 
> The guest may retrieve the wrong node and warn/crash depending on the
> implementation.
> 
> Although, it won't impact neither Xen nor the toolstack.

(To be more complete) Because Xen and the toolstack doesn't made any
usage of the phandle. The toolstack only generates the device tree and
copy necessary node from the partial DT.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.