Re: [Xen-devel] [PATCH] x86/Dom0: Don't allow dom0_max_vcpus to be zero

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/14/2015 03:21 AM, Jan Beulich wrote:
> > > > On 09.04.15 at 22:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> > On 09/04/2015 21:38, Boris Ostrovsky wrote:
> > > In case dom0_max_vcpus is incorrectly specified on boot line make sure
> > > we will still boot.
> > >
> > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Good catch - lets not do that.
> >
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I see it got committed already, and I don't really mind the change,
> but - are we really in need of this? I.e. are we really rejecting bad
> or insane command line option values everywhere else? I very
> much doubt that, and it very much looks like a "then don't do this"
> thing to me...
This actually happened to me (something happened with our installer). I 
agree that we can't predict how every option can go bad but we do try to 
prevent obvious errors so I figured this was worth a patch, especially 
given that it was pretty trivial.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel